Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the PATH env isn't set correctly under no-build-isolation #1904

Merged
merged 1 commit into from
May 9, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b5db072) 85.10% compared to head (ac6cf9c) 85.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1904   +/-   ##
=======================================
  Coverage   85.10%   85.11%           
=======================================
  Files          99       99           
  Lines        9213     9216    +3     
  Branches     1993     1993           
=======================================
+ Hits         7841     7844    +3     
  Misses        938      938           
  Partials      434      434           
Flag Coverage Δ
unittests 84.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/options.py 93.80% <ø> (ø)
src/pdm/builders/base.py 89.14% <100.00%> (+0.18%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 23ae2b7 into main May 9, 2023
@frostming frostming deleted the fix/isolation-path branch May 9, 2023 10:31
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants